Player can no longer attack enemies with one is destroyed.

Question

I've made it so that my player can successfully attack and kill an enemy however if one enemy is killed he can no longer target the others, since he found the enemy by a tag. How can I make it so that he can continue to fight other enemies? Here's my script: using UnityEngine; using System.Collections;

public class CatchJellyFish : MonoBehaviour { public float Timer; public float coolDownSwing;

 public GameObject jellyFish;
 
 
 public void Start()
 {
     Timer = 0;
     coolDownSwing = 1.0f;
     
     jellyFish = GameObject.FindGameObjectsWithTag("JellyFish");
 }

 public void Update()
 {
     if (Timer > 0)
         Timer -= Time.deltaTime;

     if (Timer < 0)
         Timer = 0;
     
     float distance = Vector3.Distance(jellyFish.transform.position, transform.position);

     if(Input.GetButton("Action1") && Time.timeScale != 0)
     {            if (Timer == 0)
         {
             Timer = coolDownSwing;
             if(distance < 8f)
             {
                 JellyFishHealth jellyHealth = (JellyFishHealth)jellyFish.GetComponent("JellyFishHealth");
                    jellyHealth.AdjustCurrentHealth(-1);
             }
         }
     }
 }

}

Answer 1

Best Answer

Answer by BiG · May 22, 2012 at 08:09 PM

First, you are assigning jellyFish's value in the Start function (so, at the beginning of the game), and you aren't going to update it in the future. So, if new enemies are generated, jellyFish variable remains useless, because its value won't change.

As a second point, FindGameObjectsWithTag returns a list: this means that you have to search, in that list, for the particular enemy that's closest to the player.

As a solution for both the problems, update jellyFish in the Update function, and use a routine that finds, during time, the closest enemy. In the Script Reference, there's an example that does exactly that.

Add comment · Show 6 · Share

matthew_tavares1 · May 22, 2012 at 10:12 PM 0

Share

I did everything that you recommended, but I keep get an error when I use unity's example at the return closest, saying that it's never assigned, even though I copied it straight from their site.

BiG · May 22, 2012 at 10:23 PM 0

Share

Copying things "straight" is not always the right approach. As an example, had you changed the tag "Enemy" from the reference script with the tag "JellyFish" (the one that you are using)? I hope that's the only thing "misaligned".

matthew_tavares1 · May 22, 2012 at 10:31 PM 0

Share

Yeah, I changed it so my code looks somewhat like this now

public class CatchJellyFish : $$anonymous$$onoBehaviour { public float Timer; public float coolDownSwing;

 public GameObject jellyFish;
 
 GameObject FindClosestJellyFish()
 {
     GameObject[] gos;
     gos = GameObject.FindGameObjectsWithTag("JellyFish");
     GameObject closest;
     float distance = $$anonymous$$athf.Infinity;
     Vector3 position = transform.position;
     foreach (GameObject go in gos)
     {
         Vector3 diff = go.transform.position - position;
         float curDistance = diff.sqr$$anonymous$$agnitude;
         if (curDistance < distance)
         {
             closest = go;
             distance = curDistance;
         }
     }
     return closest;
 }

BiG · May 22, 2012 at 10:34 PM 0

Share

O$$anonymous$$... Stupid question: are you actually calling this function in Update()? $$anonymous$$aybe you've just declared that, and you forgot to call it.

matthew_tavares1 · May 22, 2012 at 10:48 PM 0

Share

I'm sorry I'm feeling pretty dumb for not getting this. Here's how my code is right now, it's no longer giving me an error when I kill an enemy but it's randomly selecting which ones I can and cannot attack.

public class CatchJellyFish : $$anonymous$$onoBehaviour { public float Timer; public float coolDownSwing;

 public GameObject jellyFish;
 
 GameObject FindClosestJellyFish()
 {
     GameObject[] gos;
     gos = GameObject.FindGameObjectsWithTag("JellyFish");
     GameObject closest = null;
     float distance = $$anonymous$$athf.Infinity;
     Vector3 position = transform.position;
     foreach (GameObject go in gos)
     {
         Vector3 diff = go.transform.position - position;
         float curDistance = diff.sqr$$anonymous$$agnitude;
         if (curDistance < distance)
         {
             closest = go;
             distance = curDistance;
         }
     }
     return closest;
 }
 
 public void Start()
 {
     Timer = 0;
     coolDownSwing = 1.0f;
 }

 public void Update()
 {
     FindClosestJellyFish();
         
     if (Timer > 0)
         Timer -= Time.deltaTime;

     if (Timer < 0)
         Timer = 0;
     
     jellyFish = GameObject.FindGameObjectWithTag("JellyFish");
     
     float distance = Vector3.Distance(jellyFish.transform.position, transform.position);
     
     if(Input.GetButton("Action1") && Time.timeScale != 0)
     {            if (Timer == 0)
         {
             Timer = coolDownSwing;
             if(distance < 8f)
             {
                 JellyFishHealth jellyHealth = (JellyFishHealth)jellyFish.GetComponent("JellyFishHealth");
                    jellyHealth.AdjustCurrentHealth(-1);
             }
         }
     }
 }

}

Show more comments

Player can no longer attack enemies with one is destroyed.

1 Reply

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions