NullReferenceException: Object reference not set to an instance of an object

Question

I cant by the love of all things good, understand why I get the error: NullReferenceException: Object reference not set to an instance of an object MonsterSpawner.OnTriggerEnter (UnityEngine.Collider other) (at Assets/Scripts/MonsterSpawner.cs:25)

this is the part of the script that seems to be wrong? The particular line it is coplaining about is: if (!objectHit.getIsMonster())

void OnTriggerEnter(Collider other) { DamageManagement objectHit = (DamageManagement)other.GetComponent("DamageManagement"); if (!objectHit.getIsMonster()) { for (int i = 0; i < numberOfJotuns; i++) Instantiate(monster1, new Vector3(spawnPoint.x + 15 * randomBool(), spawnPoint.y - 2, spawnPoint.z + (Random.value * 10 * randomBool())), Quaternion.identity);

      Debug.Log("It Works " + randomBool());
      Destroy(this.gameObject);
  }

}

The wierd thing is that everything is working as it is supposed to do? And the if sentence works as intended as well? Its just annoying getting the error, and I would like to get rid of it.

Answer 1

Best Answer

Answer by duck · Sep 19, 2010 at 03:59 PM

It must be the case that the object which was collided with did not have a "DamageManagement" component at all (and therefore 'objectHit' would be null).

Since you're not checking whether it's null, you'll get this error.

To correct it, try this modification, which includes an explicit check for a null reference:

void OnTriggerEnter(Collider other) { DamageManagement objectHit = (DamageManagement)other.GetComponent("DamageManagement"); if (objectHit == null) { Debug.Log("collided with "+other.name+" which has no DamageManagement!"); } else { if (!objectHit.getIsMonster()) { for (int i = 0; i < numberOfJotuns; i++) Instantiate(monster1, new Vector3(spawnPoint.x + 15 * randomBool(), spawnPoint.y - 2, spawnPoint.z + (Random.value * 10 * randomBool())), Quaternion.identity);

          Debug.Log("It Works " + randomBool());
          Destroy(this.gameObject);
      }
  }

hope this solves the problem!

Add comment · Show 1 · Share

Tabu · Sep 19, 2010 at 04:33 PM 0

Share

Yes, this was indeed the problem :) Thanks The reason why this happend, was becouse each character had a weapon that collided first, and they did not have a damage$$anonymous$$anagement attached. So everything worked, just not when the weapons collided(Which they always did) I had been looking for "other.name" thanks for that also :)

Answer 2

Answer by Tabu · Sep 19, 2010 at 05:45 PM

To those interrested, this is what the working code now looks like. Again, thanks Duck :) You made my sunday evening so much greater! :D

void OnTriggerEnter(Collider other) { DamageManagement objectHit = (DamageManagement)other.GetComponent("DamageManagement"); if (objectHit != null) { //Debug.Log("collided with " + other.name + " which has no DamageManagement!");

     if (!objectHit.getIsMonster())
     {
         for (int i = 0; i &lt; numberOfJotuns; i++)
             Instantiate(monster1, new Vector3(spawnPoint.x + 15 * randomBool(), spawnPoint.y - 2, spawnPoint.z + (Random.value * 10 * randomBool())), Quaternion.identity);

         Destroy(this.gameObject);
     }
 }

}

Add comment · Share

NullReferenceException: Object reference not set to an instance of an object

2 Replies

Welcome to Unity Answers

Follow this Question

Related Questions