• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
-1
Question by Duncanrp · Sep 03, 2012 at 11:13 AM · lightingupdateoncefiring

Update() Function only fires once.

So I have a problem, my update function inside one of my scripts which flickers a light on and off only works once, here is the code:

 #pragma strict
 
 var timer = 0;
 var times = 0;
 
 public var txt : GameObject;
 
 function Start () {
 
 }
 
 function Update () {
 
     if(this.timer <= 0) {
             
         timer = 10;
         
         var light : Light;
                     
         light = this.GetComponent("Light");
 
         light.active = !light.active;
                     
     } else {
         this.timer--;
     }
         
     this.times++;    
     
 }

I'm not sure why this would be happening, any suggestions?

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0

Answer by Kryptos · Sep 03, 2012 at 12:31 PM

active is deprecated because it modifies the activation of the Gameobject not the component (this is a guess, hope someone can confirm). Therefore the script is also deactivated. You need to use enabled instead.

Furthermore, you can optimize your code by caching the reference to the Light component:

 #pragma strict
 
 var timer : int = 0;
 var times : int = 0;
 
 public var txt : GameObject;
 var myLight : Light;
 
 function Start () {
     myLight = this.GetComponent("Light");
 }
 
 function Update () {
 
     if(this.timer <= 0) {
 
        timer = 10;
  
        myLight.enabled = !myLight.enabled;
 
     } else {
        this.timer--;
     }
 
     this.times++;  
 
 }

You will need to modifiy a bit your script because it is framerate-dependent. Bu this is another issue that you can ask in another question.

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

8 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Calling a method once in update 1 Answer

Only once in update 1 Answer

Anything like run once? 1 Answer

Divide a number once in update 1 Answer

c# void Update() is only working once 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges