• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Erhan · Oct 28, 2010 at 03:00 PM · variablenullreferenceexceptiontype

C# variable type problem, always get NullRefExc

Hello. I'm playing around in Unity3D 3. I'm rewriting this JS code:

var prefabBullet:Transform;
var shootForce:float;
function Update () 
{
    if (Input.GetButtonDown("Fire1"))
    {
        var clone = Instantiate(prefabBullet, transform.position, transform.rotation);
        clone.rigidbody.AddForce(transform.forward * shootForce);
    }
}

Into C#:

using UnityEngine; using System.Collections;

public class Shoot : MonoBehaviour {

 public Transform bullet;

 void Update() {
     if (Input.GetButtonDown("Fire1")) {

         Transform clone;

         clone = Instantiate(bullet, transform.position, Quaternion.identity) as Transform;
         clone.rigidbody.AddForce(transform.forward * 1000);
     }
 }

}

But I always get a "NullReferenceException: Object reference not set to an instance of an object" when I hit my Fire1 button. I think there is a variable type problem, but I cant solve it :( Please help. Thanks, Erhan

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by skovacs1 · Oct 28, 2010 at 03:15 PM

Your translation isn't entirely off, but your problem is not one of type and would have happened in the original javascript.

Here's a literal translation of the first script:

using UnityEngine;

public class Shoot : MonoBehaviour { public Transform bullet; public float shootForce;

 void Update() {
     if (Input.GetButtonDown("Fire1")) {
         Transform clone = Instantiate(bullet, transform.position, 
                                       transform.rotation) as Transform;
         clone.rigidbody.AddForce(transform.forward * shootForce);
     }
 }

}

For help with translation, this is a useful link.

Your problem is in one of these possible locations:

  • Instantiate(bullet... - is bullet set to something?
  • clone.rigidbody... - does bullet have a Rigidbody?

You can add some checks to avoid this problem altogether:

using UnityEngine;

public class Shoot : MonoBehaviour { public Transform bullet; public float shootForce = 1000.0f;

 void Update() {
     if (Input.GetButtonDown("Fire1") && bullet && bullet.rigidbody) {
         Transform clone = Instantiate(bullet, transform.position, 
                                       transform.rotation) as Transform;
         clone.rigidbody.AddForce(transform.forward * shootForce);
     }
 }

}

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Erhan · Oct 28, 2010 at 04:26 PM 0
Share

Thank you very much! Now it works fine! :)

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

No one has followed this question yet.

Related Questions

What is typing a variable? Is it assigning the value? 3 Answers

Resources.LoadAll Issue with variable type 1 Answer

Checking if variable is nullable type? 3 Answers

What variable type is this? 1 Answer

Variable types usage 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges