Comparing variable from another script, help?

Question

Ok, so basically, I am checking the score of the player, and seeing if it is greater or equal to the price. The score number is obtained from another script. Here are the important snipets. The problem is the price is being compared but even though the score is 0, and the price is 100, the rest of the code is still carried out(player still gets weapon). The name of the other script is ScoreManager, hopefully I obtained it's variable currentScore correctly(it is set as static var)?

 var price : int = 100;


 if((!equipped && Input.GetKeyDown ("e"))||ScoreManager.currentScore >= price){
                 Debug.Log("price compared");
                 DropWeapon(weaponToDrop);
                 DeselectWeapon();

Answer 1

Best Answer

Answer by cdrandin · Jan 22, 2013 at 10:04 PM

Personally I like keeping things encapsulated within it's own script and for what ever reason if I need to get info from another script I like to make a separate function.

So. Let's say this score manager has private var score. Create a function, getScore() and return the score. It is more typing, yes, but honestly is a better approach for organization so variables aren't directly accessed outside different scripts.

I am not sure what type of gameplay you are trying to get, but make that if statement have an && instead of ||. ALSO, in close score and price with parenthesis. I.e. (ScoreManager.currentScore >= price)

Should be

 if((!equipped && Input.GetKeyDown ("e")) || (ScoreManager.currentScore >= price)){

2 Show 23 · Share

cdrandin · Jan 22, 2013 at 10:21 PM 1

Share

function getScore (){ return currentScore; }

This should be in your ScoreManager script. Now what ever script this if statement is in call it as such. GetComponent(ScoreManager).getScore(). This way, you have a cleaner method of what is going on and leave the score management up to its own script.

cdrandin · Jan 22, 2013 at 10:45 PM 1

Share

Dame, I can't remember right now, but I am assuming that your scoreManager isn't attached to anything and I don't know if scripts can be accessed if not attached to an object. Try this. Create empty game object, name it "score manager". Place ScoreManager script onto this game object. Now. Open up the score manager script and type this globally, private var scoreManager : ScoreManager. Now in the Start () function type, scoreManager = GameObject.Find("score manager").GetComponent(ScoreManager) //** this finds that empty gameobject you created which has the scoremanager script, which now gives full access to it. Now, the if statement should be...if((!equipped && Input.GetKeyDown ("e"))&&(scoreManager .getScore() >= price)){

cdrandin · Jan 22, 2013 at 10:56 PM 1

Share

yeah it will all work. The method I posted above will work. So to reiterate what it does. private var scoreManager : ScoreManager, allocated memory to prepare for the script "ScoreManager". Now in the start we want to able to access the script so we use. scoreManager = GameObject.Find("score manager").GetComponent(ScoreManager), which finds the ScoreManager, game object and then finds the script "ScoreManager", which we now have access to the functions and public/internal variables. Then in the update, we simply call the function via our pointer to the script scoreManager, so scoreManager.getScore(). Simple as that.

cdrandin · Jan 22, 2013 at 11:05 PM 1

Share

scoreManager = GameObject.Find("ScoreManager").GetComponent(ScoreManager) should be where ever, outside the ScoreManager script. If there are still errors, post both scripts some where so I can just fix it for you.

cdrandin · Jan 22, 2013 at 11:09 PM 1

Share

To help you along http://www.unity3dstudent.com/2010/07/beginner-b17-tweaking-components-via-script/. Also, check out some of their tutorials to help enforce Unity knowledge. They are simple and helpful. Also, if you are interested on a type of game, check out Unity's already created game tutorial walk thoughts at http://unity3d.com/gallery/demos/demo-projects

Show more comments

Comparing variable from another script, help?

1 Reply

Unity Answers is in Read-Only mode

Follow this Question

Related Questions