Confused about c# scripting

Question

For some reason this script is messing me up

public static PlayerInformationController PFC;

void OnGUI() { GUI.Label(new Rect(10, 70, 100, 20), "Dollars = " + PFC.curMoney); }

I believe that all of the is correct and i get no errors but when i go into debug mode i get billions of these

NullReferenceException: Object reference not set to an instance of an object
MyGUI.CharacterSkillsGUI () (at Assets/ShiftedIrony Assets/Scripts/PlayerScripts/MyGUI.cs:143)
MyGUI.OnGUI () (at Assets/ShiftedIrony Assets/Scripts/PlayerScripts/MyGUI.cs:59)

Don't really know what is messing it up but atm im trying to fix. that small script is not the entire script its just the part the the problem is located in. i don't think i need it to be public static but i put it in there anyways either way i get that error.

EDIT:

PFC SCRIPT

using UnityEngine; using System.Collections;

public class PlayerInformationController : MonoBehaviour { public int curMoney = 0; public int curHealth = 100; public int maxHealth = 100;

 private string PlayerName = "Test";

 public GUIText CharacterChat;

 public Transform playerSpawn; 

 public static MyGUI mg;

 public float healthBarLength;

 void Start () { 

     healthBarLength = Screen.width;
 }

 // Update is called once per frame
 void Update () {        
     AdjustCurrentHealth(0);
     }
 void OnGUI() {
     GUI.Label(new Rect(10, 10, 100, 20), PlayerName);       

     GUI.Box(new Rect(10, 30, Screen.width / 16, 20), curHealth + "/" + maxHealth);
 }
     public void AdjustCurrentHealth(int adj) {
             curHealth +=adj;

         if(curHealth &lt; 1)
             curHealth = 0;

         if(curHealth == 0)
             transform.position = playerSpawn.position;

         if(curHealth == 0)
             curHealth = maxHealth;

         if(curHealth &gt; maxHealth)
             curHealth = maxHealth;

         if(maxHealth &lt; 1)
             maxHealth = 1;
         }

}

Answer 1

Best Answer

Answer by Peter G · Jan 16, 2011 at 02:39 AM

NullReference would mean that your PFC is null when Unity went to check a value in it. I don't see any place where you are assigning it a reference unless you are doing it in the inspector.

You should probably do something like:

private static PlayerInformationController pfc;

public static PlayerInformationController PFC {
     get {
          if(pfc == null) {
              pfc = FindObjectOfType(typeof(PlayerInformationController)) 
                                               as PlayerInformationController;
          }
          return pfc;
     }
}

void OnGUI() {
    GUI.Label(new Rect(10, 70, 100, 20), "Dollars = " + PFC.curMoney.ToString());
}

EDIT: And I noticed, PFC.curMoney is an int and label needs a string so I fixed it for you.

Add comment · Show 2 · Share

Nynex71 · Jan 16, 2011 at 04:05 AM 0

Share

what does this mean?

Assets/ShiftedIrony Assets/Scripts/EnemyScripts/EnemyAI.cs(82,15): error CS0200: Property or indexer `EnemyAI.$$anonymous$$G' cannot be assigned to (it is read only)

Peter G · Jan 16, 2011 at 04:35 AM 0

Share

It's hard to say without seeing some of your code. Did you make a setter in your property? Or define a variable with a readonly modifier?

Confused about c# scripting

1 Reply

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions