• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Darkmoo · Jan 17, 2011 at 05:10 PM · variable

Change a Variable with another script not working (C#)

Hello, New to scripting and making a pong game with an upgrade shop. An upgrade I'm working on increases the player's speed but I have a problem communication from the Shop script to the player's paddle script.

[shop.cs]
    print("BUYING ITEM: "+itemName+" Item ID: "+itemID+" for $"+itemGold);
                plyMoney = plyMoney - itemGold;
                upgradeSpeed = upgradeSpeed +1;
                print(upgradeSpeed);
                var playerScript = GetComponent<PlayerPaddle>();
                playerScript.playerSpeed = playerScript.playerSpeed + 5;
            } else {
                print("Not enough money for item: "+itemName);
            }

The script is meant to get the playerSpeed variable from the PlayerPaddle script and then increase it by 5. But it gives me the error:

NullReferenceException: Object reference not set to an instance of an object Shop.DoMyWindow (Int32 windowID) (at Assets/ Scripts/Shop.cs:53) UnityEngine.GUI+_Window.Do () (at E:/BuildAgent/work/71ca6fec1b41cc30/Runtime/Export/Generated/GUI.cs:1152) UnityEngine.GUI.BeginWindows (UnityEngine.Event e, Int32 skinMode, UnityEngine.IDList idlist, Int32 editorWindowInstanceID) (at E:/BuildAgent/work/71ca6fec1b41cc30/Runtime/Export/Generated/GUI.cs:1372)

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by The_r0nin · Jan 17, 2011 at 07:39 PM

Is this script attached to the player? If not, then GetComponent will not return anything, since whatever you have this on has no "PlayerPaddle" script. Try caching the player GameObject in this script and getting the paddle component and player speed through that.

P.S. You might want to consider using a function in the player paddle script to increment the player speed rather than incrementing it directly. It's cleaner and segregates your code.

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Darkmoo · Jan 17, 2011 at 07:53 PM 0
Share

Thank you, I was using an empty GameObject to hold the $$anonymous$$enu/Shop script, I placed it into the player GameObject and it worked perfectly :D. Also thank you for the advice I will put it into a function for changing speed.

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

No one has followed this question yet.

Related Questions

Prefab's Script affecting all the Prefab 1 Answer

Accessing a variable within a function.... GetComponent() 2 Answers

How to increase score for objects that form larger geometries? 0 Answers

PlayerPrefs question 0 Answers

Get variables from other scripts 6 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges