• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
Question by RickyCharles · Apr 17, 2013 at 03:51 PM · positioncubecheckduplicate

Check if cube is in position before placing new cube

Hey I'm trying to build a terrain generator using cubes. I've got a random "$$anonymous$$ll" segment but when it generates it doubles up some cubes. I attempted to make an if bool type senario to check before placing but it appears to not have worked as well as I hoped.

 for(int $$anonymous$$llcount =0; $$anonymous$$llcount < 15; $$anonymous$$llcount++)
         {
             int randomy = Random.Range(0, maxy);    
             int randomz = Random.Range(0,maxz);
             int max$$anonymous$$lly = randomy + Random.Range (3,10);
             int max$$anonymous$$llz = randomz + Random.Range (3,15);
         
             for(int i2y = randomy; i2y < max$$anonymous$$lly; i2y++)
             {
                 for(int i2z = randomz; i2z < max$$anonymous$$llz; i2z++)
                 {
                     targetpos = new Vector3(0+i2y,0,0+i2z);
                     
                     if(checkIfPosEmpty(targetpos))
                     {
                     GameObject newcube = (GameObject)Instantiate(cube, new Vector3(0+i2y,1,0+i2z), Quaternion.identity);
                     newcube.name = "cube y:" + i2y + " z:" + i2z;        
                         
                 //GameObject newcube = (GameObject)Instantiate(cube, new Vector3(0+i2y,1,0+i2z), Quaternion.identity);
                 //newcube.name = "cube y2:" + i2y + " z2:" + i2z;
                     }
                 }
             }
         }
     }
             public bool checkIfPosEmpty(Vector3 targetPos)
                     {
                     GameObject[] cubes = GameObject.FindGameObjectsWithTag("cube");
                     
                     foreach(GameObject cube in cubes)
                         {
                         if(transform.position == targetPos)
                         return false;
                         }
                         return true;
                 }
Comment

People who like this

0 Show 2
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image flaviusxvii · Apr 17, 2013 at 04:19 PM 0
Share

You sure you are tagging them properly?

This is going to be an extremely slow approach btw. I'm not usually one for premature optimization, but this is just painfully slow.

avatar image RickyCharles · Apr 17, 2013 at 04:22 PM 0
Share

Already been resolved. I honestly am not too concerned with optimization at this point. I'm fairly new and this way is working for me so I'll change it later if I need to.

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

12 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Check if two objects have the same position. 2 Answers

making position checker - is area empty or not (with trigger)? 2 Answers

Cube trigger not changing position 0 Answers

How to make an "on the run" generator? 0 Answers

i want to check play position in the game so i can take an action 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges