For statement with Input.

Question

Hi, new to for statements here. I'd like to use a for statement instead of tonnes of if statements which include arrays. This is one statement that I use.

     if(Input.GetKeyDown(keys[0]))
     {
         light.color = colour[0];
     }

I'm using 2 array variables, one for keys ([0] is q right now). So when Q is pressed in-game, it changes the point light colour to the colour thats set at [0]. But for say, 25 keys ([24]), it'll be if statement after if statement, which isn't very neat. I feel that it can be shortened and I'd like to learn how.

Thank you, hope it's understandable to read.

Answer 1

Answer by nickavv · May 21, 2013 at 03:59 PM

Seems like a for loop would work fine for this:

 var i : int;
 for( i = 0; i < 25; i++) {
    if(Input.GetKeyDown(keys[i]))
     {
        light.color = colour[i];
        break; //this line will optimize, but prevent from checking for simultaneous key presses 
     }
 }

Add comment · Show 9 · Share

Julien-Lynge · May 21, 2013 at 03:59 PM 0

Share

You could speed it up ever so slightly by adding a break; statement after the assignment.

nickavv · May 21, 2013 at 04:02 PM 0

Share

Good point, but wouldn't that prevent from checking for simultaneous key presses?

Julien-Lynge · May 21, 2013 at 04:05 PM 0

Share

The behaviour of multiple key presses with the current code means that whatever pressed key comes last in the list sets the color. I'm guessing that's not a desired behaviour, but if it is, yeah, you're totally right.

nickavv · May 21, 2013 at 04:07 PM 0

Share

Ah, didn't really think about what the keypresses were actually doing. Good point. So yeah, you can probably leave the break in there, Yold

Yold · May 22, 2013 at 12:33 PM 0

Share

Thank you for your help. Appreciated loads! And also learnt something new along the way.

Show more comments

For statement with Input.

1 Reply

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions