When health is 0, character still lives

Question

Hi all. I'm a total programing noob, and This script wont work. The idea is, when the health <= 0, he it should Destroy Object. However, nothing happens, and the Health counter simply goes negative, forever... Any ideas? Thanks in advance.

 var destroyedPrefab : GameObject;
 var destroyedPrefabfx : GameObject;
 var health : int = 3;
 private var damage : int = 1;
   
 function OnCollisionEnter (col : Collision)
 {
   if(col.gameObject.tag=="Enemy")
  {
  health -= damage;
  }
  }
  
 function update (){
 
  if(health <= 0)
  {
  Destroy(gameObject);
  Instantiate(destroyedPrefab, transform.position, transform.rotation);
  Instantiate(destroyedPrefabfx, transform.position, transform.rotation);
  var guiText = GameObject.Find("GUI Text").GetComponent(GUIText);
  guiText.text = myNiceVariable;
 }
 }

Answer 1

Best Answer

Answer by talklittle · Jul 12, 2013 at 01:09 AM

Your Update function is probably not being called.

Needs to be capitalized: function Update() rather than function update().

Add comment · Show 1 · Share

Dothackking · Jul 12, 2013 at 01:14 AM 0

Share

I didn't even see that! I was wondering why his code wasn't working, because it looked fine.

Answer 2

Answer by Dothackking · Jul 12, 2013 at 01:03 AM

Here is my script as reference(note that this is from another script, but the basics should remain):

EDIT: Also, consider trying "Destroy(this.gameObject)"

 void calcDmg()
 {
     {
         targetHp = player.GetComponent <PlayerStats>().hp;
         if(targetHp - atk > 0)
         {
             player.GetComponent<PlayerStats>().hp = targetHp - atk;
             Debug.Log ("You took " + atk + " damage!");
         }
         else
         {
             player.GetComponent<PlayerStats>().hp = 0;
             Debug.Log ("You have been killed.");
             playerIsDead = true;
         }
     }
 }

Add comment · Share

When health is 0, character still lives

2 Replies

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions