• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
Question by samz · Aug 06, 2013 at 11:47 PM · timermeter

Fill up and empty meter

i have a meter that i want my player to fill up by tapping the space button = works fine.

But i also want the meter to reduce simultaneously if the player is too slow = having problems with

here is my code:

 function Update () 
 {
     if( Input.GetKeyUp(KeyCode.Space) )
     {
         Global_Counters.STONE_WALL_METER ++;
     }
     
     if( Global_Counters.STONE_WALL_METER < 9 )
     {
         ReduceMeter();
     }
 }
     
 function ReduceMeter()
 {
     yield WaitForSeconds (2.0);
     
     if( !Input.GetKeyUp(KeyCode.Space) )
     {
         var x = Global_Counters.STONE_WALL_METER - 1; 
         if( x > 0 )
         {
             Global_Counters.STONE_WALL_METER --;
         }
     }
 }
Comment

People who like this

0 Show 0
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

  • Sort: 
avatar image
Best Answer

Answer by robertbu · Aug 07, 2013 at 12:00 AM

The primary problem is that you are calling ReduceMeter() in Update. Each time you call ReduceMeter() it creates a new coroutine that is then yielded. If you app was running at 60 fps, you would stack up 120 coroutimes before the first one fires, then one (or more) would approximately fire every frame for the rest of the game.

I'm having a hard time figuring out from the code you have here under what conditions the meter should be reduces, so I don't know how to recommend a fix. You could:

  • Remove the yield and start an Invoke() repeating in Start().

  • Call ReduceMeter once and then execute the code inside in a forever loop (while(true)) inside ReduceMeter.

  • Use a time or timestamp.

My guess is that you want the last one. Something like this (untested):

 var timeStamp : float;
 var waitTime = 2.0;
 
 function Start() {
     timeStamp = Time.time + waitTime;
 }
 
 function Update () 
 {
     if( Input.GetKeyUp(KeyCode.Space) )
     {
        Global_Counters.STONE_WALL_METER ++;
        timeStamp = Time.time + waitTime;
     }
  
     if( Global_Counters.STONE_WALL_METER < 9  && timeStamp < time.Time)
     {
        ReduceMeter();
        timeStamp = Time.time + waitTime;
     }
 }
  
 function ReduceMeter()
 { 
        if( Global_Counters.STONE_WALL_METER > 1 )
        {
          Global_Counters.STONE_WALL_METER --;
        }
     }
 }

  
Comment
samz

People who like this

1 Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image samz · Aug 07, 2013 at 12:07 AM 0
Share

that is exactly what i needed! My guardian angel in coding has once again saved me

Unity Answers is in Read-Only mode

Unity Answers content will be migrated to a new Community platform and we are aiming to launch a public beta by June 9. Please note, Unity Answers is now in read-only so we can prepare for the final data migration.

For more information and updates, please read our full announcement thread in the Unity Forum.

Follow this Question

Answers Answers and Comments

14 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Add Delay to Moving Platform 1 Answer

Timer Freeze Problem 1 Answer

How to set text(timer) to a fixed place 1 Answer

Countdown 2 Answers

c#- how to display time score in a new scene 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges