• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
Question by William · Sep 05, 2013 at 08:15 PM · wont stop

enemy explode

i want my enemy to destroy and explode but it wont

 var life = 0;
 var explosion : GameObject;
  
 function OnCollisionEnter(boom : Collision) {
     if (explosion.active == false)
         if(boom.gameObject.tag == "bullet")
         {
            life +=1;
            if(life == 30)
                Destroy(gameObject);
            explosion.SetActiveRecursively(true);
         }
 }
Comment

People who like this

0 Show 6
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Sajidfarooq · Sep 05, 2013 at 08:27 PM 0
Share

You forgot the braces '{' and '}' before line 10 and after 11 respectively.

avatar image flaviusxvii · Sep 05, 2013 at 08:31 PM 0
Share

I reformatted your code. I don't see any syntax problems with braces.

avatar image Sajidfarooq · Sep 05, 2013 at 08:33 PM 0
Share

@flaviusxvii: He wants to destroy the gameobject (line 10) and activate the explosion (line 11) but his "if" doesn't have braces so it only recognizes the line immediately after the if (which is line 10)...

avatar image flaviusxvii · Sep 05, 2013 at 08:35 PM 0
Share

Ahh.. this is why I ALWAYS USE BRACES AROUND BLOCKS. Nice catch.

avatar image flaviusxvii · Sep 05, 2013 at 08:42 PM 0
Share

@Sajidfarooq the first bullet will activate the explosion (assuming it is inactive to begin with), and then no further collisions will enter if(boom...

Show more comments

2 Replies

  • Sort: 
avatar image
Best Answer

Answer by Sajidfarooq · Sep 05, 2013 at 09:44 PM

You forgot the braces '{' and '}' before line 10 and after 11 respectively, i.e, after the if(life==30) block. Your code should look like this:

 var life = 0;
 var explosion : GameObject;
  
 function OnCollisionEnter(boom : Collision) 
 {
 if (explosion.active == false)
     if(boom.gameObject.tag == "bullet")
     {
     life +=1;
     if(life == 30)
         {
         Destroy(gameObject);
         explosion.SetActiveRecursively(true);
         }
     }
 }

  

The problem, as-is, is that the first bullet hit will "always" cause an explosion, regardless of whether life = 30 or not.

Comment

People who like this

0 Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image William · Sep 05, 2013 at 10:25 PM 0
Share

Il go try it thank you

avatar image

Answer by William · Sep 05, 2013 at 09:49 PM

Ok so all i need is brackets on if

        {if}(life == 30)
Comment

People who like this

0 Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Sajidfarooq · Sep 05, 2013 at 09:51 PM 0
Share

No, see my answer. Also, please don't use the "answer" tool to add a comment, like you did. Answers are only for...well...answers, not clarifications.

Furthermore, when you like an answer, remember to mark it as "answered" so that others can benefit by knowing what the correct solutions is.

Unity Answers is in Read-Only mode

Unity Answers content will be migrated to a new Community platform and we are aiming to launch a public beta by June 9. Please note, Unity Answers is now in read-only so we can prepare for the final data migration.

For more information and updates, please read our full announcement thread in the Unity Forum.

Follow this Question

Answers Answers and Comments

17 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Mouse Look Script 1 Answer

For Loop Won't Stop Running... 1 Answer

I can't create a world border? 1 Answer

Particle system stop? 3 Answers

How to make Timer stop upon Death? 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges