• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Trollvahkiin · Sep 17, 2013 at 07:42 PM · stateonofftorch

How to turn a flashlight on/off with LMB? (JS)

Hey,

so I started making this script in JS where you can turn it on and off with RMB. This is what I got so far.

 #pragma strict
 
 var torchState : boolean;
 
 function Start()
 {
     torchState = true;
 }
 
 function Update()
 {
     if (Input.GetButtonDown("Fire1") && torchState)
     {
         GetComponent(Light).enabled = false;
         torchState = false;
     }
     if (Input.GetButtonDown("Fire1") && !torchState)
     {
         GetComponent(Light).enabled = true;
         torchState = true;
     }
 }

It doesn't work at all. Any ideas what is wrong with it?

Comment
Add comment · Show 2
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Seth-Bergman · Sep 17, 2013 at 07:52 PM 0
Share

are there any errors?

avatar image Trollvahkiin · Sep 17, 2013 at 07:59 PM 0
Share

NO errors.

1 Reply

· Add your reply
  • Sort: 
avatar image
1
Best Answer

Answer by Eric5h5 · Sep 17, 2013 at 08:05 PM

The logic in your code goes like this: you check for button down, and turn the torch off if it's on. Then you check for button down, and turn it on if it's off, which it always is, because you just turned it off. You'd need to use if/else, or better yet, don't bother with any of that stuff, and just toggle the light instead.

 function Update () {
     if (Input.GetButtonDown("Fire1")) {
         GetComponent(Light).enabled = !GetComponent(Light).enabled;
     }
 }
Comment
Add comment · Show 3 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image Trollvahkiin · Sep 17, 2013 at 08:10 PM 0
Share

Works perfectly, but how? It just says that light enabled is equal to light not being enabled?

avatar image TrickyHandz · Sep 17, 2013 at 08:13 PM 0
Share

What is happening is the enabled property of the Light is being set to the opposite value. So if enabled is false, it is set to true and vice versa.

It is shorthand for the following:

 if(GetComponent(Light).enabled == true)
    GetComponent(Light).enabled = false;
 else
    GetComponent(Light).enabled = true;

However, since you are doing it the way @Eric5h5 suggests, you save time on the process since you simply toggle the value rather than having to check the value first.

avatar image Seth-Bergman · Sep 17, 2013 at 08:16 PM 0
Share

(to elaborate) you can switch a boolean to its opposite value this way.. example:

 var switch : boolean = true;

 switch = !switch;
 //(switch now equals false)
 switch = !switch;
 //(equals true again)

Component.enabled is a boolean, so this works..

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

19 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Light script flashes on and off 1 Answer

Particle on and off 1 Answer

Turn off a script and then back on? 3 Answers

turn OnMouseDrag on and off 1 Answer

Show GUI texture then not 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges