• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Sondre-S · Jan 08, 2014 at 09:53 PM · traffic

Is this a good way to make a traffic light?

I've put together a simple traffic light script, it works great. It's changing textures and shaders on the three lightbulb meshes dependig on what light is active. Now I'm gonna use this for many traffic lights in a city and I was wondering what would be the best approach. I was thinking: 1. use one mesh for all the traffic lights(and control it with one script) 2. or make a traffic light game object with a mesh and script and clone it?

Any thoughts apperciated :)

 ////// Trafic light script
 #pragma strict
 var RedMesh:Transform;
 var GreenMesh:Transform;
 var YellowMesh:Transform;
 
 var Lit : Texture;
 var Unlit : Texture;
 
 var shaderNormal : Shader; 
 var shaderEmissive : Shader; 
 
 var Seconds:float;
 var Red:float=15;
 var Yellow:float=3;
 var Green:float=15;
 private var TrafTimer:float;
 
 function Start () {
 shaderNormal = Shader.Find( "VertexLit" );
 shaderEmissive = Shader.Find( "Self-Illumin/VertexLit" );
 }
 
 function Update () 
 {
 TrafTimer += Seconds;
 
 // light is red
 if(TrafTimer > 0 && TrafTimer < Red) 
 {
 
 RedMesh.renderer.material.SetTexture("_MainTex", Lit);
 RedMesh.renderer.material.shader = shaderEmissive;
 
 YellowMesh.renderer.material.SetTexture("_MainTex", Unlit);
 YellowMesh.renderer.material.shader = shaderNormal;
 
 GreenMesh.renderer.material.SetTexture("_MainTex", Unlit);
 GreenMesh.renderer.material.shader = shaderNormal;
 
 }
 // light is yellow
 if(TrafTimer > Red && TrafTimer < (Red+Yellow))  
 {
  
  RedMesh.renderer.material.SetTexture("_MainTex", Unlit);
  RedMesh.renderer.material.shader = shaderNormal;
 
 YellowMesh.renderer.material.SetTexture("_MainTex", Lit);
 YellowMesh.renderer.material.shader = shaderEmissive;
 
 GreenMesh.renderer.material.SetTexture("_MainTex", Unlit);
 GreenMesh.renderer.material.shader = shaderNormal;
  
 }
 // light is green
 if(TrafTimer > (Red+Yellow) && TrafTimer < (Red+Yellow+Green)) 
 {
  
  RedMesh.renderer.material.SetTexture("_MainTex", Unlit);
  RedMesh.renderer.material.shader = shaderNormal;
 
 YellowMesh.renderer.material.SetTexture("_MainTex", Unlit);
 YellowMesh.renderer.material.shader = shaderNormal;
 
 GreenMesh.renderer.material.SetTexture("_MainTex", Lit);
 GreenMesh.renderer.material.shader = shaderEmissive;
  
 }
 // light is yellow 
 if(TrafTimer > (Red+Yellow+Green)) 
 {
  
  RedMesh.renderer.material.SetTexture("_MainTex", Unlit);
  RedMesh.renderer.material.shader = shaderNormal;
 
 YellowMesh.renderer.material.SetTexture("_MainTex", Lit);
 YellowMesh.renderer.material.shader = shaderEmissive;
 
 GreenMesh.renderer.material.SetTexture("_MainTex", Unlit);
 GreenMesh.renderer.material.shader = shaderNormal;
  
 }
 // Reset light 
 if(TrafTimer >= Red+Yellow+Green+Yellow) 
 {
 TrafTimer=0;
 }
 
 
 }
 
 function OnGUI () {
     GUI.Label (Rect (20, 10, 300, 40), "timer: "+TrafTimer);
     
 }
Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer

Answer by Bunny83 · Jan 08, 2014 at 10:07 PM

Uhm, well, good for what? You might want to take a look at my answer on this similar question.

Generally there are many ways how something can be done. In your code it would make more sense to declare your "Red/Yellow/GreenMesh" variables as Renderer and not Transform. Using the ".renderer" shortcut-property adds unnecessary overhead.

Next thing is it would make more sense to simply use seperate materials (6 mats so 2 for each color).

Comment
Add comment · Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

19 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

making a traffic system 2 Answers

Trying to get paths from container[Solved] 2 Answers

How to make vehicles sense and obey traffic lights? 1 Answer

Finding center and/or lanes of road mesh 0 Answers

Add penalty to previous path on point graph to prevent u-turns? A* Pathfinding Project 1 Answer


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges