• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
Question by sheffieldlad · Feb 07, 2014 at 05:31 PM · c#prefabtriggerenemybullet

bullets kill all enemies, not just the ones hit.

Hi all, I have several enemies walking around my level chasing the player but when I shoot one, all of them take damage.

Here is my code attached to my bullet prefab

 public class Bullet : MonoBehaviour {
 
     public float lifeSpan = 3;
     static private Enemy myEnemy;
 
 
     // Use this for initialization
     void Start () {
 
         gameObject.GetComponent<CapsuleCollider>().isTrigger = true;
         StartCoroutine(kill());
 
         if ((myEnemy = GameObject.FindObjectOfType(typeof(Enemy)) as Enemy) ==null)
 
         {
             Debug.Log("No Enemies to Shoot!!");
         }
     
     }
 
     void OnTriggerEnter(Collider other)
 
     {
         if(myEnemy !=null)
 
         {
 
         if    (other.gameObject.tag == "Enemy")
 
             {
                 Debug.Log("Hit! " + other.name);
                 myEnemy.takeDamage(10);
                 Die();
             }
 
             else
 
             {
                 Debug.Log ("Hit! " + other.name);
                 Die();
             }
         }
 
     }
     // Update is called once per frame
     void Update () {
     
     }
 
     void Die()
 
     {
 
         Destroy(this.gameObject);
     }
 
     protected IEnumerator kill()
     {
         yield return new WaitForSeconds(lifeSpan);
         Destroy(gameObject);
     }
 }


and here is my code attacked to my enemy..

public class Enemy : MonoBehaviour {

 static private Player mainPlayer;
 public enum EnemyType{Green, Purple, Red};
 public float mHealth = 20.0f;
 private float mMaxHealth = 20.0f;
 [SerializeField]
 private EnemyType enemyType = EnemyType.Purple;


 void Awake()
     
 {
     if(mainPlayer == null)
     {
         
         if((mainPlayer = GameObject.FindGameObjectWithTag("Player").GetComponent<Player>()) == null)
         {
             if((mainPlayer = GameObject.FindObjectOfType(typeof(Player)) as Player) == null)
             {
                 Debug.LogError("Cannot locate main player");
             }
         }
     }
 }

 public void takeDamage(float amount)
     
 {
     mHealth -= amount;
     
     if(mHealth <=0)
         
     {
         dieEnemy();
     }
     
     
 }

 // Use this for initialization
 void Start () {
     initEnemy(enemyType);
 }
 
 // Update is called once per frame
 void Update () {
 

 
 
 }


 public void dieEnemy ()
 {
     Destroy (gameObject);
 }


 public void initEnemy(EnemyType newEnemyType)
 {
     switch(newEnemyType)
     {
     case EnemyType.Purple:
         mHealth = 20.0f;
         mMaxHealth = 15.0f;
         break;
     case EnemyType.Green:
         
         mHealth = 20.0f;
         mMaxHealth = 20.0f;
         break;
         
     case EnemyType.Red:
         
         mHealth = 20.0f;
         mMaxHealth = 10.0f;
         break;
         
     }
     
 }

}

Can anyone tell me why this is happening?

TIA.

Comment

People who like this

0 Show 0
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

· Add your reply
  • Sort: 
avatar image
Best Answer

Answer by Andrew_Kenady · Feb 07, 2014 at 06:34 PM

Try changing this:


 if    (other.gameObject.tag == "Enemy")
  
          {
           Debug.Log("Hit! " + other.name);



to this:


 if (other.gameObject.tag == "Enemy")
 {
      myEnemy = other.gameObject.GetComponent<Enemy>();
      Debug.Log("Hit! " + other.name);



As far as I can tell, you're not telling the specific enemy to die when colliding.

On a side note, you can change lines like this:


 if ((myEnemy = GameObject.FindObjectOfType(typeof(Enemy)) as Enemy) ==null)


to something like this:


 if (GameObject.FindObjectOfType<Enemy>() == null)


Hope this helps!

Comment
sheffieldlad

People who like this

1 Show 1 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image sheffieldlad · Feb 07, 2014 at 06:57 PM 0
Share

Many thanks :)

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

19 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

my enemy is broken 1 Answer

Instantiated Prefab Trigger not firing. 0 Answers

Enemy doesn't shoot 1 Answer

Checking Tag of Trigger Prefab 1 Answer

Stopping a bullet but letting the animation continue 2 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges