Inventory Script. List Contains. I dont know the need bit of code.[UNSOLVED]

Question

I dont know the needed code for the script to check if the Players inventory has a Iron Ingot from line...

  if (PlayerInventory.Inventory.Contains(_worldItemProperties))

_WorldItemProperties is a variable holding the script WorldItemProperties

I thought it would be like this...

  if (PlayerInventory.Inventory.Contains(_worldItemProperties.ItemName ("Iron Ingot")))

I want it to check if the List (Named Inventory) has a Iron Ingot (Iron Ingot is held by a variable named ItemName in the Item class WorldItemProperties which is put into the List.)

When I do that I get...

error CS1955: The member `WorldItemProperties.ItemName' cannot be used as method or delegate

I have NO idea what that even means...I have Googled it, nothing matched my case nor did anything make sense (Thats the internet for me...)

Script with issue

 WorldItemProperties _worldItemProperties;
 void Awake(){
 
 _worldItemProperties = GetComponent<WorldItemProperties>();
 
 }
 public void InventoryWindow(int id)
 {
      if (GUI.Button (new Rect (5, 20, ButtonWidth, ButtonHeight), BronzeBar))
      {
         if (PlayerInventory.Inventory.Contains(_worldItemProperties))
         {
             PlayerInventory.Inventory.Remove (_worldItemProperties);
         }
      }
 }

WorldItemProperties

using UnityEngine; using System.Collections;

[System.Serializable] public class WorldItemProperties : MonoBehaviour {

 public string ItemName = "";
 public Texture2D InvItemTexture;
 public string ItemDescription = "";

}

PlayerInvenotory.Inventory

 using UnityEngine;
 using System.Collections;
 using System.Collections.Generic;
 
 public class PlayerInventory : MonoBehaviour {
 
     private static List<WorldItemProperties> _inventory = new List<WorldItemProperties>();
     public static List<WorldItemProperties> Inventory {
                 get{ return _inventory;}
         }
 }

I have already asked on forums and they have answered in a way that makes no sense to me and left me to rot... Simple Google search's didn't do any good either.

Answer 1

Best Answer

Answer by whydoidoit · Feb 19, 2014 at 04:53 PM

Right best bet is to use FindIndex with a predicate:

 var index = PlayerInventory.Inventory.FindIndex(item=>item.ItemName == "Iron Ingot");
 if(index >= 0)
      PlayerInventory.Inventory.RemoveAt(index);

Add comment · Show 3 · Share

Ethanbf3 · Feb 19, 2014 at 05:49 PM 0

Share

@whydoidoit Ah, it seems to work! :)

Never seen this sort of code before, going to need to look into it to understand it. Cheers!

whydoidoit · Feb 20, 2014 at 01:29 AM 0

Share

No problem - look for closures and lambda syntax in .NET stuff. There's stuff on it over on http://unitygems.com

You should also check out Linq (again article on Gems)

whydoidoit · Feb 20, 2014 at 01:30 AM 0

Share

Oh and could you tick the answer please :)

Answer 2

Answer by deltamish · Feb 18, 2014 at 02:41 PM

Try using

 if(_worldItemProperties.ItemName == "Iron Ingot")
 {
  //
 }

rather tthan

 _worldItemProperties.ItemName ("Iron Ingot")enter code here

EDIT

Try this .You should never check if an string is eaual to another string inside of Contains method.Intead use this piece of code

  if (PlayerInventory.Inventory.Contains(_worldItemProperties))
 {
  int index = PlayerInventory.Inventory.IndexOf(_worldItemProperties);
 
 if(PlayerInventory.Inventory[index].ItemName == "Iron Ingot")
 {
 // Do something fun if the above statement is satisfied 
 }
 }

Add comment · Show 6 · Share

Ethanbf3 · Feb 18, 2014 at 02:50 PM 0

Share

Nope, didnt work...

I did try...(I assumed you meant this...) [CODE] if (PlayerInventory.Inventory.Contains(_worldItemProperties.ItemName == "Iron Ingot")) [/CODE]

and in return I got...

[QUOTE]error CS1502: The best overloaded method match for System.Collections.Generic.List.Contains(WorldItemProperties)' has some invalid arguments [/QUOTE] [QUOTE] error CS1503: Argument #1' cannot convert bool' expression to type WorldItemProperties' [/QUOTE]

I also tried it like so... [CODE] if(_worldItemProperties.ItemName == "Iron Ingot") [/CODE]

then I got the Null error

whydoidoit · Feb 18, 2014 at 03:02 PM 0

Share

Can you confirm if the code you have posted is correct and you have the if statement outside the body of the Awake?

deltamish · Feb 18, 2014 at 03:13 PM 0

Share

I did try...(I assumed you meant this...) [CODE] if (PlayerInventory.Inventory.Contains(_worldItemProperties.ItemName == "Iron Ingot")) [/CODE]

You cant equate a string in Contains function I will rpost my answer in a while check it out

whydoidoit · Feb 18, 2014 at 03:15 PM 2

Share

It should be like this:

 WorldItemProperties _worldItemProperties;
 void Awake(){
  
     _worldItemProperties = GetComponent<WorldItemProperties>();
  
 
     if (PlayerInventory.Inventory.Contains(_worldItemProperties))
     {
         PlayerInventory.Inventory.Remove (_worldItemProperties);
     }
 }

Ethanbf3 · Feb 19, 2014 at 04:39 PM 0

Share

@deltamish Nope didnt get the desired result on the edit.

@whydoidoit Yes, it is confirmed that the if statement is outside the Awake function. It is under a GUI.Button which is under a OnGUI function.

In response to your solution...s Thats the exact same code as I posted, also didnt get the desired result.

@Everyone (Everyone meaning all posters) I will be updating the question shortly to fill any gaps and hopefully make the issue clearer. :)

Show more comments

Inventory Script. List Contains. I dont know the need bit of code.[UNSOLVED]

2 Replies

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions