Question by ClassicGameJunkie · Mar 21, 2014 at 08:34 PM · javascript destroy projectile fire nullreferenceexeption

Projectile Script Works Until Destroying Projectile

So I have a script that launches a projectile from a position on a button press, it works fine, the projectiles start firing and stacking up. So naturally I want to make sure they get destroyed after a short while to save memory etc.

But when I add the destruction line I get a NullReferenceException : Object reference not set to an instance. The code so far is below. Any ideas how I would remedy this? Thanks.

 var projectile : Rigidbody;
 var speed = 50;
  
 var fireRate = 0.11;
 private var lastShot = -10.0;
  
 function Update () {
 if(Input.GetButton("Fire1")){
     if(Time.time > fireRate+lastShot){
         clone = Instantiate(projectile, transform.position, transform.rotation);
         projectile.tag = "Fireball";
         clone.velocity = transform.TransformDirection( Vector3 (0, 0, speed));
  
         lastShot = Time.time;
     }
 Destroy(clone.gameObject, 3);
 }
 }

0 Show 4

ShadoX · Mar 21, 2014 at 08:37 PM 0

Which line do you get the NullPointerException on ? (if you click on the error in the console, it should open the script editor with the cursor at the line which is causing the Exception)

Also have you tried doing

 Destroy(clone, 3);

instead ? I don't see how only destroying the attached gameObject would free up memory if you'd leave everything else intact.. (or perhaps I'm just wrong about that)

robertbu · Mar 21, 2014 at 08:40 PM 0

Try moving line 16 to line 13.

Sildaekar · Mar 21, 2014 at 08:50 PM 0

Btw, all this instantiating and destroying is going to make a huge impact on performance, if I were you I'd look into object pooling.

ClassicGameJunkie · Mar 21, 2014 at 08:50 PM 0

The error happens on line 16 as in

 Destroy(clone.gameObject, 3);

The desired effect is that the projectile disappears a second after launching. This script is attached to an empty object, pressing "Fire1" fires the projectile but it crashes the instant the projectile should be deleted and gives me the error.

Removing the word gameObject stops the crash, but doesn't delete the projectile.

Appreciate the help so far!

Update: Ah thankyou ShadoX moving the line worked!

However I'm curious robertbu, why will it impact performance? The projectiles are destroyed after 3 seconds, do they remain in the memory even after destruction?

Unity Answers is in Read-Only mode

Unity Answers content will be migrated to a new Community platform and we are aiming to launch a public beta by June 9. Please note, Unity Answers is now in read-only so we can prepare for the final data migration.

For more information and updates, please read our full announcement thread in the Unity Forum.