• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
This question was closed Sep 30, 2015 at 07:43 AM by meat5000.
avatar image
0
Question by cow_co · Jul 13, 2014 at 11:24 AM · c#nullreferenceexception

NullReferenceException: Object Reference Not Set To An Instance Of An Object

So I have a script that I have put onto a weapon, which is parented to the player's hand. The player game object has a script called PlayerClass that has the list of stats for te player. when the weapon hits an enemy, the weapon script is called:

 using UnityEngine;
 using System.Collections;
 
 public class WeaponAttackScript : MonoBehaviour 
 {
     public delegate void WeaponHit ();  /*this is necessary for the event*/
     public static event WeaponHit OnHit;  /*sets up the event so that we know when the weapon hits an enemy*/
 
     // Use this for initialization
     void Start () 
     {
     
     }
     
     // Update is called once per frame
     void Update () 
     {
 
     }
 
     void OnTriggerEnter(Collider enemyCollider)   /*trigger allows us to avoid the terrain-flying bug.*/
     {
         if(enemyCollider.gameObject.tag=="Enemy")
 
         {
             PlayerClass playerStats = this.gameObject.transform.parent.GetComponent<PlayerClass>(); /*for getting player's strength*/
             InventoryItemClass weaponType = GetComponent<InventoryItemClass>();/*the item class, needed for
             getting the base damage*/
             EnemyTypeClass enemyType = enemyCollider.gameObject.GetComponent<EnemyTypeClass>(); /*references
             enemy's type to get armour rating (see next line)*/
             float enemyArmourRating = enemyType.armourRating; /*self-explanatory*/
             float baseDamage =  weaponType.itemDamage;        /*"*/
             float attackerStrength = playerStats.strength;    /*"*/
             float damageDealt = (baseDamage/enemyArmourRating)*(attackerStrength/100.0f);
             if (PlayerClass.isAttacking == true)  /*just need to sort out the double-hit issue*/
                 
             {
                 enemyType.health = enemyType.health - damageDealt;
                 OnHit ();
                 Debug.Log ("Hit for " + damageDealt + " damage");
                 
             }
         }
 
     }
 }
         

but when I hit the enemy, this error message pops up:

NullReferenceException: Object reference not set to an instance of an object WeaponAttackScript.OnTriggerEnter (UnityEngine.Collider enemyCollider) (at Assets/scripts/CombatScripts/WeaponAttackScript.cs:33)

where have I gone wrong?

Edit: I fixed it by using GetComponentInParent instead of this.gameObject.transform.parent.GetComponent, but I still wouldn't mind knowing why the previous method didn't work.

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

  • Sort: 
avatar image
0

Answer by coutlass-supreme · Sep 30, 2015 at 06:33 AM

A duplicate of this one

http://answers.unity3d.com/questions/380349/nullreferenceexception-with-an-event.html

Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

3 People are following this question.

avatar image avatar image avatar image

Related Questions

Can't explain an NRE 0 Answers

NullReferenceException 1 Answer

Trouble with Null Reference in Script 2 Answers

C# Textfield Null Reference Exception 1 Answer

An object reference that seems pretty set-to-an-instance-of-an-object to me 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges