Cant pickup papers with script

Question

I cant pickup papers with script , with "E" , and i dont know why.

 #pragma strict
 @script RequireComponent( AudioSource )
 
 var papers : int = 0;
 var papersToWin : int = 8;
 var distanceToPaper : float = 2.5;
 
 public var paperPickup : AudioClip;
 
 var theEnemy : EnemyScript;
 
 
 
 
 function Start() 
 {
     Screen.lockCursor = true;
     
     // find and store a reference to the enemy script (to reduce distance after each paper is collected)
     if ( theEnemy == null )
     {
         theEnemy = GameObject.Find( "Enemy" ).GetComponent( EnemyScript );
     }
 }
 
 
 function Update() 
 { 
     //if ( Input.GetMouseButtonUp(0) ) // use E in editor as LockCursor breaks with left mouseclick
     if ( Input.GetMouseButtonDown(0) || Input.GetKeyDown(KeyCode.E) ) 
     {
         //var ray = Camera.main.ScreenPointToRay( Input.mousePosition ); // always cast ray from center of screen
         var ray = Camera.main.ScreenPointToRay( Vector3( Screen.width * 0.5, Screen.height * 0.5, 0.0 ) );
         var hit : RaycastHit;
         if ( Physics.Raycast( ray, hit, distanceToPaper ) )
         {
             //if ( hit.collider.gameObject.tag == "Paper" )
             if ( hit.collider.gameObject.name == "Paper" )
             {
                 papers += 1;
                 //Debug.Log( "A paper was picked up. Total papers = " + papers );
                 
                 audio.PlayClipAtPoint( paperPickup, transform.position ); 
                 
                 Destroy( hit.collider.gameObject );
                 
                 // make enemy follow closer
                 theEnemy.ReduceDistance();
             }
         }
     }
 }
 
 
 function OnGUI()
 {
     if ( papers < papersToWin )
     {
         GUI.Box( Rect( (Screen.width * 0.5) - 60, 10, 120, 25 ), "" + papers.ToString() + " Papers Collected" );
     }
     else
     {
         GUI.Box( Rect( (Screen.width/2)-100, 10, 200, 35 ), "All Papers Collected!" );
         // Application.LoadLevel( "sceneWin" );
     }
 }

Answer 1

Answer by ExplodingCookie · Jul 17, 2014 at 10:50 PM

,To answer your question. Try using this in place of your reference to the key.

 Input.GetKeyDown("e")

Hopefully this solves your issue. :)

~ExplodingCookie

0 Show 4 · Share

Jetzz · Jul 17, 2014 at 10:54 PM 0

Share

Its the same. :(

ExplodingCookie · Jul 17, 2014 at 10:58 PM 1

Share

I'm aware they will do the same thing in theory. But using this always works for me. The best way to solve a problem is to tinker around with things.

ExplodingCookie · Jul 17, 2014 at 11:00 PM 1

Share

Have you tried restarting Unity?

Jetzz · Jul 18, 2014 at 01:14 AM 0

Share

Yes i restart but nothing

Answer 2

Answer by Kiwasi · Jul 18, 2014 at 03:10 AM

Here is a debugged version of your update function. You should see all of the messages in the console. I suggest commenting each one out once you have seen it, messaging the console will slow the game down.

This will allow you to isolate which line is not working. Post back once you have figured it out.

 function Update() 
 { 
     Debug.Log("Update is working");
     if ( Input.GetMouseButtonDown(0) || Input.GetKeyDown(KeyCode.E) ) 
     {
         Debug.Log("Inut is working");
         var ray = Camera.main.ScreenPointToRay( Vector3( Screen.width * 0.5, Screen.height * 0.5, 0.0 ) );
         var hit : RaycastHit;
         if ( Physics.Raycast( ray, hit, distanceToPaper ) )
         {
             Debug.Log("Raycast is working");
             if ( hit.collider.gameObject.name == "Paper" )
             {
                 Debug.Log("Name checking is working");
                 papers += 1;
                 audio.PlayClipAtPoint( paperPickup, transform.position ); 
                 Destroy( hit.collider.gameObject );
                 theEnemy.ReduceDistance();
             }
         }
     }
 }

0 Show 5 · Share

Jetzz · Jul 18, 2014 at 03:13 AM 0

Share

Update is working , and Inut is working

Kiwasi · Jul 18, 2014 at 03:23 AM 1

Share

Now we are getting somewhere. The problem is in your raycast. Let me have a look at that a little more closely and get back to you.

Kiwasi · Jul 18, 2014 at 03:35 AM 1

Share

Try adding the following line immediately after your var ray.

 Debug.DrawRay(ray.origin, ray.direction * distanceToPaper, Color.white, 1, false);

This should draw the line in your scene view. Is this line coming anywhere near your paper collider?

Jetzz · Jul 18, 2014 at 07:04 PM 0

Share

Now the code is this:

 #pragma strict
 @script RequireComponent( AudioSource )
 
 var papers : int = 0;
 var papersToWin : int = 3;
 var distanceToPaper : float = 5.5;
 
 public var paperPickup : AudioClip;
 
 var theEnemy : EnemyScript;
 
 
 
 
 function Start() 
 {
     Screen.lockCursor = true;
     
     // find and store a reference to the enemy script (to reduce distance after each paper is collected)
     if ( theEnemy == null )
     {
         theEnemy = GameObject.Find( "Enemy" ).GetComponent( EnemyScript );
     }
 }
 
 
  
 function Update() 
 { 
     Debug.Log("Update is working");
     if ( Input.GetMouseButtonDown(0) || Input.GetKeyDown(KeyCode.E) ) 
     {
         Debug.Log("Inut is working");
         var ray = Camera.main.ScreenPointToRay( Vector3( Screen.width * 0.5, Screen.height * 0.5, 0.0 ) );
         Debug.DrawRay(ray.origin, ray.direction * distanceToPaper, Color.white, 1, false);
         var hit : RaycastHit;
         if ( Physics.Raycast( ray, hit, distanceToPaper ) )
         {
             Debug.Log("Raycast is working");
             if ( hit.collider.gameObject.name == "Paper" )
             {
                 Debug.Log("Name checking is working");
                 papers += 1;
                 audio.PlayClipAtPoint( paperPickup, transform.position ); 
                 Destroy( hit.collider.gameObject );
                 theEnemy.ReduceDistance();
             }
         }
     }
 }
 
 
 function OnGUI()
 {
     if ( papers < papersToWin )
     {
         GUI.Box( Rect( (Screen.width * 0.5) - 60, 10, 120, 25 ), "" + papers.ToString() + " Papers Collected" );
     }
     else
     {
         GUI.Box( Rect( (Screen.width/2)-100, 10, 200, 35 ), "All Papers Collected!" );
         // Application.LoadLevel( "sceneWin" );
     }
 }

The debug doesnt make any line

Jetzz · Jul 18, 2014 at 08:22 PM 0

Share

I think the problem is here: if ( Physics.Raycast( ray, hit, distanceToPaper ) )

Cant pickup papers with script

2 Replies

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions