Array Element Issues

Question

So for the game i am making i require an array to hold 50 string elements. What i want to happen is when the player pushes a button the script randomly chooses a number and finds the corrosponding element. I then want the script to then show the selected element in some sort of GUI output such as a label. I get it to work but after a random number of presses i get an error saying it cannot cast from source type to destination type. I was thinking of changing the script to C# and use lists but the sake of continuity i was just seeing if what i could do was possible.

 function OnGUI() {
   GUI.Label(Rect(50,50,50,50),ChosenSong,"label");
   if (GUI.Button(Rect(Screen.width/2,Screen.height/2,150,50),Toggle)){
     Song = Random.Range(0,playlist.length);
     ChosenSong = playlist[Song];
     playlist.RemoveAt(Song);
   }
 }

Answer 1

Answer by Eric5h5 · Nov 12, 2014 at 05:16 AM

Never use the JS Array class. Use generic lists instead, and make sure the type of the variable matches the type of the list.

Add comment · Share

Answer 2

Answer by Jeff-Kesselman · Nov 11, 2014 at 02:25 PM

The maximum index of an array is array.Length-1, not array.Length

Add comment · Show 5 · Share

Jeff-Kesselman · Nov 11, 2014 at 06:06 PM 0

Share

I have no idea why you down voted this. It is the correct answer.

Fix this line:

Song = Random.Range(0,playlist.length);

MrSoad · Nov 11, 2014 at 06:18 PM 0

Share

I don't think he could have down voted you, he has to have 100 karma to do that and he has no down votes on his page.

Voted you both back up :)

PS: Not Landern either so don't blame him :D

Jeff-Kesselman · Nov 11, 2014 at 06:20 PM 0

Share

Fair enough :)

ZiggySawdust · Nov 12, 2014 at 04:52 AM 0

Share

yea i didnt vote you down and i made your correction thank you for pointing tht out but i still get the same error

Eric5h5 · Nov 12, 2014 at 05:12 AM 0

Share

I just downvoted this answer because it's incorrect. Random.Range used with integers is exclusive on the upper bound; see the docs. Random.Range (0, array.Length) is correct. If you use array.Length-1, it will never choose the last item in the array.

Array Element Issues

2 Replies

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions