• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
Question by KravenArk · Nov 12, 2014 at 10:40 PM · gunammo

Sleep Syntax Unity

I need some help with the syntax for a script. I have tried WaitForSeconds but it only stops the function that it is in. Basically I'm making a gun script. In which I can input how much ammo in is the gun and when I press the fire button it fires and subtracts one bullet from the clip. And the problem I have is that when I reload I can still pull the trigger and it subtracts the clip into negative numbers. This will mess up later when I Instantiate bullets into the scene so I need to fix it right now.

in case its tl;dr, here is the deal. I need to know the syntax of how to stop the entire script after the computer reads one line. In older languages such as qbasic it's called "sleep". here is my script.

  var bulletsinclip : int;
  var bulletsinclipfull : int;
  var time : float = 20.0f;
  var time2 : float = 20;
  function AmmoDeduction () {
  bulletsinclip = bulletsinclip - 1;
  }
   function Reload(time2 : float) {
      transform.Translate(Vector3.forward * Time.deltaTime * 100);
      yield WaitForSeconds(time2);
      transform.Translate(Vector3.back * Time.deltaTime * 100);
       bulletsinclip = bulletsinclipfull;
  }
  
  function Shoot(time : float) {
      transform.Translate(Vector3.forward * Time.deltaTime * 10);
      AmmoDeduction();
      yield WaitForSeconds(time);
      transform.Translate(Vector3.back * Time.deltaTime * 10);
  }
  
  function Update() {
      if (bulletsinclip < 0) {
      Reload (0.7);
      }
      if (Input.GetButtonDown("Fire1")) {
           Shoot(0.1);
      }
      }

Comment

People who like this

0 Show 0
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

1 Reply

  • Sort: 
avatar image

Answer by Kiwasi · Nov 12, 2014 at 11:31 PM

I would suggest rolling this all into a single coroutine.

Pseudo code (C#)

 void Start (){
     StartCoroutine(Firing());
 }
 
 IEnumerator Firing(){
     while (true){
         while (bulletsinclip > 0) {
             if (Input.GetButtonDown("Fire1")) {
                 yield return StartCoroutine(Shoot(0.1f));
             } else {
                 yield return null;
             }
         }
         yield return StartCoroutine(Reload (0.7f));
     }
 }

Two key principles to note

  • You can yield the a coroutine. This will stop execution of the outer coroutine until the inner coroutine is complete.

  • You can use a while loop with a yield statement to create repetitive behaviour. Save your work first, its easy to create an infinite loop here. Unity cannot recover from an infinite loop in your code

Comment
KravenArk

People who like this

1 Show 2 · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image KravenArk · Nov 13, 2014 at 04:11 PM 0
Share

what should i do with the functions i have written. Should i replace them with corountines?

avatar image Kiwasi · Nov 13, 2014 at 06:00 PM 0
Share

Your functions already are coroutines. The syntax for C# and JavaScript is quite different here.

Unity Answers is in Read-Only mode

Unity Answers content will be migrated to a new Community platform and we are aiming to launch a public beta by June 9. Please note, Unity Answers is now in read-only so we can prepare for the final data migration.

For more information and updates, please read our full announcement thread in the Unity Forum.

Follow this Question

Answers Answers and Comments

27 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Gun Script not working help please 2 Answers

I Made a Revolver Script, But It's Saying There is an Error 2 Answers

Zombie FPS 2 Answers

having trouble with ammo reload script. destorys extra ammo 1 Answer

I want to be able to make a good shoot script that actually works. 0 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges