• Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learning
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Wilsh · Nov 20, 2014 at 08:35 PM · c#playercontrollerboxcollider

Help with player controller

Hello, I have been following a tutorial on creating a player controller using Rays and box colliders. I'm unsure why it won't work as my player object keeps falling through the ground. Here is the code and the ground + player has box colliders and the layer mask is attached to the ground only.

 [RequireComponent(typeof(BoxCollider))]
 public class PlayerPhysics : MonoBehaviour {
     public LayerMask collisionMask;
     private BoxCollider collider;
     private Vector3 s;
     private Vector3 c;
 
     private float skin = .005f;
 
     [HideInInspector]
     public bool grounded;
         Ray ray;
 
     RaycastHit hit;
 
     void Start() {
 
                 collider = GetComponent<BoxCollider> ();
                 s = collider.size;
                 c = collider.center;
 
         }
     public void Move(Vector2 moveAmount) {
 
         float deltaY = moveAmount.y;
         float deltaX = moveAmount.x;
             Vector2 p = transform.position;
 
         grounded = false;
 
         for(int i = 0; i < 3; i++)
         {
             float dir = Mathf.Sign(deltaY);
             float x = (p.x + c.x + s.x/2) + s.x/2 * i;
             float y = p.y + c.y + s.y/2 * dir;
 
             ray = new Ray(new Vector2(x,y), new Vector2(0,dir));
             Debug.DrawRay(ray.origin,ray.direction);
             if (Physics.Raycast(ray,out hit,Mathf.Abs(deltaY),collisionMask));
             {
                 float dst = Vector3.Distance(ray.origin, hit.point);
 
                 if(dst > skin){
                     deltaY = dst * dir + skin;
                 }
                 else {
                     deltaY = 0;
                 }
                 grounded = true;
                 break;
             }
 
         }
 
         Vector2 finalTransform = new Vector2 (deltaX, deltaY);
         transform.Translate (moveAmount);
 }
 }


 using System.Collections;
 [RequireComponent(typeof(PlayerPhysics))]
 public class PlayerController : MonoBehaviour {
     public float gravity = 20;
     public float speed = 8;
     public float acceleration = 12;
     public float jumpHeight = 12;
 
     private float currentSpeed;
     private float targetSpeed;
     private Vector2 amountToMove;
 
     public PlayerPhysics playerPhysics;
     // Use this for initialization
     void Start () {
         playerPhysics = GetComponent<PlayerPhysics>();
     }
     
     // Update is called once per frame
     void Update () {
     
         targetSpeed = Input.GetAxisRaw ("Horizontal") * speed;
 
         currentSpeed = IncrementTowards (currentSpeed, targetSpeed,acceleration);
         if (playerPhysics.grounded) {
             amountToMove.y = 0;
             
             // Jump
             if (Input.GetButtonDown("Jump")) {
                 amountToMove.y = jumpHeight;    
             }
         }
 
         amountToMove.x = currentSpeed;
         amountToMove.y -= gravity * Time.deltaTime;
         playerPhysics.Move(amountToMove * Time.deltaTime);
     }
 
     private float IncrementTowards(float n, float target, float speed){
                 if (n == target) {
                         return n;
                 } else {
                         float dir = Mathf.Sign (target - n);
                         n += speed * Time.deltaTime * dir;
                         return (dir == Mathf.Sign (target - n)) ? n : target;
                 }
         }
 }
 

Comment
Add comment
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

0 Replies

· Add your reply
  • Sort: 

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

If you’re new to Unity Answers, please check our User Guide to help you navigate through our website and refer to our FAQ for more information.

Before posting, make sure to check out our Knowledge Base for commonly asked Unity questions.

Check our Moderator Guidelines if you’re a new moderator and want to work together in an effort to improve Unity Answers and support our users.

Follow this Question

Answers Answers and Comments

2 People are following this question.

avatar image avatar image

Related Questions

Camera and Controls 4 Answers

Third person controller 1 Answer

Controller Movement!! 1 Answer

Negative Positions Breaks Raycasts 1 Answer

my ball sometimes jumps higher or sometimes not 2 Answers


Enterprise
Social Q&A

Social
Subscribe on YouTube social-youtube Follow on LinkedIn social-linkedin Follow on Twitter social-twitter Follow on Facebook social-facebook Follow on Instagram social-instagram

Footer

  • Purchase
    • Products
    • Subscription
    • Asset Store
    • Unity Gear
    • Resellers
  • Education
    • Students
    • Educators
    • Certification
    • Learn
    • Center of Excellence
  • Download
    • Unity
    • Beta Program
  • Unity Labs
    • Labs
    • Publications
  • Resources
    • Learn platform
    • Community
    • Documentation
    • Unity QA
    • FAQ
    • Services Status
    • Connect
  • About Unity
    • About Us
    • Blog
    • Events
    • Careers
    • Contact
    • Press
    • Partners
    • Affiliates
    • Security
Copyright © 2020 Unity Technologies
  • Legal
  • Privacy Policy
  • Cookies
  • Do Not Sell My Personal Information
  • Cookies Settings
"Unity", Unity logos, and other Unity trademarks are trademarks or registered trademarks of Unity Technologies or its affiliates in the U.S. and elsewhere (more info here). Other names or brands are trademarks of their respective owners.
  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges