• Products
  • Solutions
  • Made with Unity
  • Learn
  • Support & Services
  • Community
  • Asset Store
  • Get Unity

UNITY ACCOUNT

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account
  • Blog
  • Forums
  • Answers
  • Evangelists
  • User Groups
  • Beta Program
  • Advisory Panel

Navigation

  • Home
  • Products
  • Solutions
  • Made with Unity
  • Learn
  • Support & Services
  • Community
    • Blog
    • Forums
    • Answers
    • Evangelists
    • User Groups
    • Beta Program
    • Advisory Panel

Unity account

You need a Unity Account to shop in the Online and Asset Stores, participate in the Unity Community and manage your license portfolio. Login Create account

Language

  • Chinese
  • Spanish
  • Japanese
  • Korean
  • Portuguese
  • Ask a question
  • Spaces
    • Default
    • Help Room
    • META
    • Moderators
    • Topics
    • Questions
    • Users
    • Badges
  • Home /
avatar image
0
Question by Alex_TNT · Mar 24, 2015 at 06:20 AM · unity 5javascript

Change car models on keypress

Can someone help me minimize and develop more of this code, There are 24 different cars 12 normal 12 cop cars, would be nice if I could press a key ( Spacebar) and would cycle/change trough normal cars on every press, and once I press a specific key let's say (P) from police it will switch to that version of cop car

 var model_01: GameObject;
 var model_02: GameObject;
 var model_03: GameObject;
 var model_04: GameObject;
 var model_05: GameObject;
 var model_06: GameObject;
 var model_07: GameObject;
 var model_08: GameObject;
 var model_09: GameObject;
 var model_10: GameObject;
 var model_11: GameObject;
 var model_12: GameObject;
 
 
 function Start()
 {
 
 model_01.SetActive(true);
 model_02.SetActive(false);
 model_03.SetActive(false);
 model_04.SetActive(false);
 model_05.SetActive(false);
 model_06.SetActive(false);
 model_07.SetActive(false);
 model_08.SetActive(false);
 model_09.SetActive(false);
 model_10.SetActive(false);
 model_11.SetActive(false);
 model_12.SetActive(false);
 }
 
 function Update(){
 if (Input.GetKeyDown ("1"))
 {
 model_01.SetActive(true);
 model_02.SetActive(false);
 model_03.SetActive(false);
 model_04.SetActive(false);
 model_05.SetActive(false);
 model_06.SetActive(false);
 model_07.SetActive(false);
 model_08.SetActive(false);
 model_09.SetActive(false);
 model_10.SetActive(false);
 model_11.SetActive(false);
 model_12.SetActive(false);
 }
 else if  (Input.GetKeyDown ("2"))
 {
 model_01.SetActive(false);
 model_02.SetActive(true);
 model_03.SetActive(false);
 model_04.SetActive(false);
 model_05.SetActive(false);
 model_06.SetActive(false);
 model_07.SetActive(false);
 model_08.SetActive(false);
 model_09.SetActive(false);
 model_10.SetActive(false);
 model_11.SetActive(false);
 model_12.SetActive(false);
 }
 else if  (Input.GetKeyDown ("3"))
 {
 model_01.SetActive(false);
 model_02.SetActive(false);
 model_03.SetActive(true);
 model_04.SetActive(false);
 model_05.SetActive(false);
 model_06.SetActive(false);
 model_07.SetActive(false);
 model_08.SetActive(false);
 model_09.SetActive(false);
 model_10.SetActive(false);
 model_11.SetActive(false);
 model_12.SetActive(false);
 }
 else if  (Input.GetKeyDown ("4"))
 {
 model_01.SetActive(false);
 model_02.SetActive(false);
 model_03.SetActive(false);
 model_04.SetActive(true);
 model_05.SetActive(false);
 model_06.SetActive(false);
 model_07.SetActive(false);
 model_08.SetActive(false);
 model_09.SetActive(false);
 model_10.SetActive(false);
 model_11.SetActive(false);
 model_12.SetActive(false);
 }
 else if  (Input.GetKeyDown ("5"))
 {
 model_01.SetActive(false);
 model_02.SetActive(false);
 model_03.SetActive(false);
 model_04.SetActive(false);
 model_05.SetActive(true);
 model_06.SetActive(false);
 model_07.SetActive(false);
 model_08.SetActive(false);
 model_09.SetActive(false);
 model_10.SetActive(false);
 model_11.SetActive(false);
 model_12.SetActive(false);
 }
 else if  (Input.GetKeyDown ("6"))
 {
 model_01.SetActive(false);
 model_02.SetActive(false);
 model_03.SetActive(false);
 model_04.SetActive(false);
 model_05.SetActive(false);
 model_06.SetActive(true);
 model_07.SetActive(false);
 model_08.SetActive(false);
 model_09.SetActive(false);
 model_10.SetActive(false);
 model_11.SetActive(false);
 model_12.SetActive(false);
 }
 else if  (Input.GetKeyDown ("7"))
 {
 model_01.SetActive(false);
 model_02.SetActive(false);
 model_03.SetActive(false);
 model_04.SetActive(false);
 model_05.SetActive(false);
 model_06.SetActive(false);
 model_07.SetActive(true);
 model_08.SetActive(false);
 model_09.SetActive(false);
 model_10.SetActive(false);
 model_11.SetActive(false);
 model_12.SetActive(false);
 }
 else if  (Input.GetKeyDown ("8"))
 {
 model_01.SetActive(false);
 model_02.SetActive(false);
 model_03.SetActive(false);
 model_04.SetActive(false);
 model_05.SetActive(false);
 model_06.SetActive(false);
 model_07.SetActive(false);
 model_08.SetActive(true);
 model_09.SetActive(false);
 model_10.SetActive(false);
 model_11.SetActive(false);
 model_12.SetActive(false);
 }
 else if  (Input.GetKeyDown ("9"))
 {
 model_01.SetActive(false);
 model_02.SetActive(false);
 model_03.SetActive(false);
 model_04.SetActive(false);
 model_05.SetActive(false);
 model_06.SetActive(false);
 model_07.SetActive(false);
 model_08.SetActive(false);
 model_09.SetActive(true);
 model_10.SetActive(false);
 model_11.SetActive(false);
 model_12.SetActive(false);
 }
 else if  (Input.GetKeyDown ("0"))
 {
 model_01.SetActive(false);
 model_02.SetActive(false);
 model_03.SetActive(false);
 model_04.SetActive(false);
 model_05.SetActive(false);
 model_06.SetActive(false);
 model_07.SetActive(false);
 model_08.SetActive(false);
 model_09.SetActive(false);
 model_10.SetActive(true);
 model_11.SetActive(false);
 model_12.SetActive(false);
 }
 else if  (Input.GetKeyDown ("-"))
 {
 model_01.SetActive(false);
 model_02.SetActive(false);
 model_03.SetActive(false);
 model_04.SetActive(false);
 model_05.SetActive(false);
 model_06.SetActive(false);
 model_07.SetActive(false);
 model_08.SetActive(false);
 model_09.SetActive(false);
 model_10.SetActive(false);
 model_11.SetActive(true);
 model_12.SetActive(false);
 }
 else if  (Input.GetKeyDown ("="))
 {
 model_01.SetActive(false);
 model_02.SetActive(false);
 model_03.SetActive(false);
 model_04.SetActive(false);
 model_05.SetActive(false);
 model_06.SetActive(false);
 model_07.SetActive(false);
 model_08.SetActive(false);
 model_09.SetActive(false);
 model_10.SetActive(false);
 model_11.SetActive(false);
 model_12.SetActive(true);
 }
 }
Comment
Add comment · Show 6
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users
avatar image abi-kr01 · Mar 24, 2015 at 06:31 AM 0
Share

Run this thing in update() instead of Start()

avatar image Alex_TNT · Mar 24, 2015 at 06:56 AM 0
Share

it is running in Update(), it just declaring what to be visible at Start() and what not

avatar image soft_sound · Mar 25, 2015 at 12:59 AM 0
Share

Why not loop through the cars and check if it has a certain name then display said car, so name police cars policeModelA, policeModelB, etc and check if the name contains "police" or "cop". etc

Also I personally would just use 4 controls, left and right to go down the list, and up and down to swap car type. I would put the cars into different lists or layer the list so 1-4 is a cop car and 5-8 is some other car and when you are searching for cop cars if you get to element 5 you either stop at 4 or jump back to 1.

etc...

avatar image smallbit · Mar 27, 2015 at 09:31 AM 0
Share

Use Input.GetKeyDown(KeyCode.Alpha0) for "0" Input.GetKeyDown(KeyCode.Alpha1) for "1" etc...

also there are tons of ways to make your code clearer. For instance you could put them into array of type Transform[] than write a method that resets all cars (iterate over array). and than on each button you could just first reset all the cars and than call array[0].gameObject.SetActive(true). for example...

avatar image Parzivell · Mar 27, 2015 at 11:00 AM 0
Share

Instead of using model_11.SetActive(false); Use model_11.gameObject.SetActive(false); I'm sure that's your problem

Show more comments

1 Reply

· Add your reply
  • Sort: 
avatar image
0
Best Answer Wiki

Answer by Alex_TNT · Mar 27, 2015 at 11:18 AM

code on unity forum I made with help of 2 guys

 public var cars : GameObject[];
 public var carsPolice : GameObject[];
 // What car is active at start
 public var carNumber:int = 2;
  
  
 function Start ()
 {
    for( var i: int=0; i < cars.Length; i++){
    cars[i].SetActive(false);
    }
    cars[carNumber].SetActive(true);
 }
  
   function Update(){
      if (Input.GetKeyUp ("space"))
   {
   if(carNumber < cars.Length -1) {
   carNumber++;
   } else {
   carNumber=0;
   }
   changeCars(carNumber);
   }
      // Toggle Police Version of the car
      if (cars[carNumber].activeInHierarchy == true && Input.GetKeyDown ("p")){
      cars[carNumber].SetActive(false);
      carsPolice[carNumber].SetActive(true);
      }
      else if(Input.GetKeyDown ("p"))
      {
      cars[carNumber].SetActive(true);
      carsPolice[carNumber].SetActive(false);
      }
      //
   }
    
   function changeCars(carNumber:int){
   for( var i: int=0; i < cars.Length; i++){
   cars[i].SetActive(false);
        carsPolice[i].SetActive(false);
   }
   cars[carNumber].SetActive(true);
  
   }
Comment
Add comment · Share
10 |3000 characters needed characters left characters exceeded
▼
  • Viewable by all users
  • Viewable by moderators
  • Viewable by moderators and the original poster
  • Advanced visibility
Viewable by all users

Your answer

Hint: You can notify a user about this post by typing @username

Up to 2 attachments (including images) can be used with a maximum of 524.3 kB each and 1.0 MB total.

Welcome to Unity Answers

The best place to ask and answer questions about development with Unity.

To help users navigate the site we have posted a site navigation guide.

If you are a new user to Unity Answers, check out our FAQ for more information.

Make sure to check out our Knowledge Base for commonly asked Unity questions.

If you are a moderator, see our Moderator Guidelines page.

We are making improvements to UA, see the list of changes.

Follow this Question

Answers Answers and Comments

6 People are following this question.

avatar image avatar image avatar image avatar image avatar image avatar image

Related Questions

Raycast Pause Between Hits? 0 Answers

Setting Scroll View Width GUILayout 1 Answer

Can i use Standard Assets into my project? 2 Answers

what is the newer version of this piece of code? -1 Answers

All the material are lost after build for Desktop but are visible in unity editor, Please Help!!! 0 Answers

  • Anonymous
  • Sign in
  • Create
  • Ask a question
  • Spaces
  • Default
  • Help Room
  • META
  • Moderators
  • Explore
  • Topics
  • Questions
  • Users
  • Badges