Piece of code including foreach loop not working correctly

Question

Everytime I press play, "Distance" is always 0… What am I doing wrong?

 if (DataValue == CubeManagerGet.GetComponent <CubeManager> ().CurrentCube)
         {
             TextGet.text = "Coordinates: {" + transform.position.x + ", " + transform.position.y + "}";
             Debug.Log ("YES");
             GameObject [] Cubes = GameObject.FindGameObjectsWithTag ("Cube");
             float Distance = Mathf.Infinity;
             foreach (GameObject CubeTag in Cubes)
             {
                 if (Vector3.Distance (transform.position, CubeTag.transform.position) < Distance)
                 {
                     Distance = Vector3.Distance (transform.position, CubeTag.transform.position);
                 }
                 if (Distance <= 5)
                 {
                     CanSubtract = true;
                 }
                 else
                 {
                     CanSubtract = false;
                 }
             }
             Debug.Log (Distance);
         }

Answer 1

Best Answer

Answer by sumeeton · Mar 29, 2015 at 03:45 PM

Why this statement?

 if (Vector3.Distance (transform.position, CubeTag.transform.position) < Distance)

Is any of your cube at position of the object the script is attached to? Remove the above check.

Edit your loop as following:

 foreach (GameObject CubeTag in Cubes)
 {
       Distance = Vector3.Distance (transform.position, CubeTag.transform.position);
     if (Distance <= 5)
     {
          CanSubtract = true;
         }
     else
     {
          CanSubtract = false;
     }
      Debug.Log(Distance);
 }

Add comment · Show 28 · Share

awplays49 · Mar 29, 2015 at 03:48 PM 0

Share

So that it sets distance to the smallest distance. However, I am trying to make an alternative solution that doesnt mean checking if there is something there.

This code is supposed to delete the current cube, then check every slot and the lowest one that exists if the one the camera is teleported to. However, its not working.

 if (Action == Actions.Subtract && Cube$$anonymous$$anagerGet.GetComponent <Cube$$anonymous$$anager> ().CubeCount > 1)
         {
             Destroy (Cube$$anonymous$$anagerGet.GetComponent <Cube$$anonymous$$anager> ().Cubes [Cube$$anonymous$$anagerGet.GetComponent <Cube$$anonymous$$anager> ().CurrentCube]);
             TextGet.text = "No Cube Selected";
             TextGet.color = Color.red;
             for (int CubeReplace = 0; CubeReplace < Cube$$anonymous$$anagerGet.GetComponent <Cube$$anonymous$$anager> ().Cubes.Count; CubeReplace ++)
             {
                 if (Cube$$anonymous$$anagerGet.GetComponent <Cube$$anonymous$$anager> ().Cubes [CubeReplace] != null)
                 {
                     Cube$$anonymous$$anagerGet.GetComponent <Cube$$anonymous$$anager> ().CurrentCube = CubeReplace;
                     Camera.main.transform.position = new Vector3 (Cube$$anonymous$$anagerGet.GetComponent <Cube$$anonymous$$anager> ().Cubes [Cube$$anonymous$$anagerGet.GetComponent <Cube$$anonymous$$anager> ().CurrentCube].transform.position.x, Cube$$anonymous$$anagerGet.GetComponent <Cube$$anonymous$$anager> ().Cubes [Cube$$anonymous$$anagerGet.GetComponent <Cube$$anonymous$$anager> ().CurrentCube].transform.position.y, 0);
                     break;
                 }
             }
         }

sumeeton · Mar 29, 2015 at 03:52 PM 0

Share

The distance is not reset in the loop. How can you be sure that the cubes in the loop are in the descending order of the distance. Your current check will ignore most of the cubes.

sumeeton · Mar 29, 2015 at 03:58 PM 0

Share

I hope you are getting it. What if the first calculated distance is 0? Try removing the check.

awplays49 · Mar 29, 2015 at 04:09 PM 0

Share

I already got rid of that code.. It would have been not very efficient apparently so i have heard. Im trying to make a game with an ortho camera looking at cubes and you can remove and add cubes. when you remove, however, i want it to delete yourself, and then you just click on another block to inhabit that block. it could possibly leave you on a screen, though, where there is no blocks to click, and thats what im having trouble with.

sumeeton · Mar 29, 2015 at 04:20 PM 0

Share

Okay! What about the distance now? Does the debug shows different distances? Your code isn't neat. Sorry for that. I am unable to understand the algorithm you are implementing.

Show more comments

Answer 2

I went through your code and fixed a couple of things, I removed something that you need to put back (only because i don't have the whole code, so for instance the first if statement, and the CanSubtract which is now a simple Debug (just put back your own code).

Although i don't really understand what you're trying to do, here's the code that worked and let me know if you need anything else, Distance is successfully changing and the if tests are working. Thanks for voting up and accepting as "Answered".

 using UnityEngine;
 using System.Collections;
 
 public class HasMoved : MonoBehaviour {
 
     public GameObject [] Cubes;
     float Distance;
 
     void Start(){
         Debug.Log( "Coordinates: {" + transform.position.x + ", " + transform.position.y + "}");
         Cubes = GameObject.FindGameObjectsWithTag ("Cube");
 
         Distance = Mathf.Infinity;
     }
 
     void Update(){
         foreach (GameObject CubeTag in Cubes)
         {
             if (Vector3.Distance (transform.position, CubeTag.transform.position) < Distance)
             {
                 Distance = Vector3.Distance (transform.position, CubeTag.transform.position);
             }
             if (Distance <= 5)
             {
                 Debug.Log("Can Subtract True");
             }
             else
             {
                 Debug.Log("Can Subtract False");
             }
         }
         Debug.Log (Distance);
     }
 
 }

Piece of code including foreach loop not working correctly

2 Replies

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions