Multiple shops

Question

  Using UnityEngine.UI;
  
  public Text display;
  public string displayText;
  
  void Update(){
  float dist = Vector3.Distance(transform.position, player.position);
  
  if(dist<=3){
      display.text = displayText;
  }
  else{
      display.text = "";
  }
  }

If I attach the script to the shopkeepers, logically it doesn't work. But is there another way of doing this? ^^

Answer 1

Best Answer

Answer by ethestel · Apr 07, 2015 at 07:42 AM

Hello,

Your algorithm is correct, however I would like to suggest a few things:

You didn't specified what "player" field references to. If it is a game object, then you should use player.transform.position instead of player.position.
You are calling "display" objects "text" setter function with the same string on each Update call, which is ideally called 60 times per second. I would recommend that you only update text when players distance status changes.

1 Show 6 · Share

Bokaii · Apr 07, 2015 at 08:07 AM 0

Share

Well how would I do this?

And the player object is a Transform, because I'm only using it as a transform (for the position)

ethestel · Apr 07, 2015 at 08:36 AM 0

Share

Here you go, hope this helps:

 using UnityEngine;
 using UnityEngine.UI;
 
 public class Shopkeeper : MonoBehaviour {
 
     public Text display;
     public string displayText;
     public Transform player;
     //this field will store if the text is on screen
     private bool m_isTextShown;
 
     void Start()
     {
         //set initial text
         UpdateText(false);
     }
 
     void Update(){
         float dist = Vector3.Distance(transform.position, player.position);
 
         //show text if player is in distance AND text is not on screen
         if(dist <= 3f  &&  ! m_isTextShown)
         {
             UpdateText(true);
         }
         //hide text if player is out of distance AND text is on screen
         else if(dist > 3f  &&  m_isTextShown)
         {
             UpdateText(false);
         }
     }
 
     private void UpdateText(bool showText)
     {
         Debug.Log("update");
         m_isTextShown = showText;
         display.text = (showText) ? displayText : "";
     }
 
 }

Bokaii · Apr 07, 2015 at 10:19 AM 0

Share

But will this not do the exact same, and if I add the script to multiple objects/ shopkeepers, only 1 of them will work and display the text?

ethestel · Apr 07, 2015 at 10:55 AM 0

Share

The result is same as yours, shopkeeper displays a text when player gets closer. But addressing the issue i reminded on my original answer, this is much more efficient than replacing text field around 60 times each second with same string.

It will work fine with multiple shopkeepers and single player, attach this script on each shopkeeper game object, and target the player on each of them.

Bokaii · Apr 07, 2015 at 12:32 PM 0

Share

Thank you it did work.

But just a quick question, is it just the boolean that makes it so it works with multiple shops?

Show more comments

Answer 2

If I where you I would go the more simpler route and use OnTriggerEnter and attach it to a invisible cube with the box collider set to trigger. in the vicinity of the shopkeeper where you want the player to use the shop that the player walks into. I'll create a simple example for you.

 using UnityEngine;
 using System.Collections;
 
 public class Shopkeeper : MonoBehaviour {
     bool activated = false;
     void OnGUI () {
         if (activated == true) {
                         Debug.Log ("Welcome to the store");
                 }
     }
     
     // Update is called once per frame
     void OnTriggerEnter (Collider theCollision) {
         if (theCollision.tag == "Player")
             activated = true;
         else
             activated = false;
     }
 }

Replace the OnGUI if debug line to your shopkeeper's gui script. when the player walks up to the shopkeeper it will display your gui code and when the player walks away from the shop keeper it will remove the gui. Also remember to set the tag of your Player to Player for this to work. For any other DIFFERENT shop you want to create just copy the script, change the class name and the gui code. if you want to create another shop of the SAME kind just create the shop keeper again and the invisible cube with the box collider set to trigger and put the shopkeeper script above on it with your edited gui code. ALSO PLEASE don't forget to upvote this if it helped you, it took me some time to make this.

Multiple shops

2 Replies

Unity Answers is in Read-Only mode

Follow this Question

Related Questions