What's wrong with my raycasthit2D?

Question

I'm making a character move on top of tiles based on a raycasthit2d that is supposed to assess each tile for various checks before actually moving the player. The problem is that I can't quite grasp the concept of Raycasthit2D for some reason (and I'm kind of dodgy when it comes to calling other scripts). Here's a bit of code that isn't functional at all, and I just can't seem to find out where things are going wrong:

UPDATED CODE STILL NOT FUNCTIONAL

using UnityEngine; using System.Collections;

public class Player1 : MonoBehaviour {

 public int playerID = 1;
 public int pHP = 1000;
 public float spotX = -4.2f;
 public float spotY = -0.25f;
 public LayerMask NotToHit;
 Transform rightPoint;


 // Use this for initialization

 void Awake ()
 {
     rightPoint = transform.FindChild("RightPoint");
 }

 void Start () {
 
 }
 
 // Update is called once per frame
 void Update () {
     //Vector3 spot = new Vector3( spotX, spotY, 0);

 //    Vector3 origin = new Vector3 (this.transform.position.x, this.transform.position.y, 0);
 //    origin = new Vector2(this.transform.position.x, this.transform.position.y);

     Vector2 rightFacing = new Vector2 (rightPoint.position.x, rightPoint.position.y);
 
     if(Input.GetKeyDown(KeyCode.RightArrow))
     {
         RaycastHit2D moveCheck = Physics2D.Raycast (rightFacing, Vector2.right, 2.9f, NotToHit);
         if (moveCheck.collider != null)
         {
             Debug.DrawRay(transform.position, Vector3.right, Color.cyan);

             Debug.Log(moveCheck.collider.name);
             Tile tileInfo = GetComponent<Tile>();
             Debug.Log ("Got tile comp");
             bool canMove = tileInfo.moveable;
             if(tileInfo.moveable == true)
             {
                 Debug.Log("TRUUUUUUUUUU");
                 spotX = spotX + 1.25f;
                 transform.position = new Vector3(spotX, spotY, 0);
         
             }
         }
     }

The raycasthit is supposed to assess each tile to ensure that a bool variable named "moveable" is true, but it just let's me go anywhere. I can even move off of the grid entirely. I really just need to know what's preventing this from working. Pardon the weak coding, I'm still adjusting to Unity.

UPDATE: I since created a new empty GameObject called "RightPoint" placed at the right-most corner in my Player collider with NotToHit LayerMask set to not detect the Player layer. The Player object IS in fact in the Player layer, yet moveCheck.collider.name is still returning "Player" on the console. Why is this happening?? I have no clue why it isn't detecting the tiles instead.

Answer 1

Best Answer

Answer by barbe63 · May 25, 2015 at 03:53 AM

That drawned my attention:

  NotToHit

It seems you have misunderstood the LayerMask. It's used to tell what layers are to hit, not the opposite. ;)

Add comment · Show 7 · Share

TheDreamEXE · May 25, 2015 at 03:57 AM 0

Share

Wait, seriously? I honestly have no clue how Layer$$anonymous$$asks are used. I spent a clean 45 $$anonymous$$ looking up examples and I ran across a Bracket's tutorial that used it the same way I did to not hit the player

barbe63 · May 25, 2015 at 04:15 AM 0

Share

I do a lot of raycasts in my project, I guarantee you it's working that way. Give it a try :p $$anonymous$$aybe Bracket did something like inversing the value of his mask somewhere?

TheDreamEXE · May 25, 2015 at 09:37 PM 0

Share

That worked! Now how exactly do I access a variable from my tile after it hits?

barbe63 · May 25, 2015 at 10:33 PM 0

Share

First declare this:

 RaycastHit hit;

Then replace your raycast with this:

 RaycastHit2D moveCheck = Physics2D.Raycast (rightFacing, Vector2.right,out hit, 2.9f, layermask); //the out will make some output you can use

Then right after that you can use for example this:

 if(hit.collider.gameObject.CompareTag("TagName")) //usefull to filter gameObject, you can also use layers(faster) to identify or name(slower)
 {
     value = hit.collider.gameObject.GetComponent<SomeClass>().somePublicValue;
 //or
    hit.collider.gameObject.GetComponent<SomeClass>().somePublic$$anonymous$$ethod();
 }

TheDreamEXE · May 26, 2015 at 01:47 AM 0

Share

Interesting idea. Raycast2D doesn't have an "out" parameter like the normal Raycast does though. I'm messing with my code right now trying to mimic this effect somehow. You're a huge help though :)

Show more comments

Answer 2

Answer by maccabbe · May 24, 2015 at 02:56 PM

It seems that you have accidentally put a semicolon at the end of your if statement. To the compiler

 if(tileInfo.moveable == true);
 {
     Debug.Log("Input");
     spotX = spotX + 1.25f;
     transform.position = new Vector3(spotX, spotY, 0);
 }

reads the same as

 if(tileInfo.moveable == true){}
 
 if(true){
     Debug.Log("Input");
     spotX = spotX + 1.25f;
     transform.position = new Vector3(spotX, spotY, 0);
 }

Remove the semicolon and your if statement should work correctly

 if(tileInfo.moveable == true)
 {
     Debug.Log("Input");
     spotX = spotX + 1.25f;
     transform.position = new Vector3(spotX, spotY, 0);
 }

Side note, it is usually better to just use if(bool) instead of if(bool==true)

Add comment · Show 1 · Share

TheDreamEXE · May 25, 2015 at 03:31 AM 0

Share

whoops. Noted the semi-colon. That still didn't fix my problem though. I just have no clue what I'm doing wrong with raycasting

What's wrong with my raycasthit2D?

2 Replies

Your answer

Welcome to Unity Answers

Follow this Question

Related Questions